Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 202533003: Don't schedule an animation during compositing dirty-bit setting unless needed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments from abarth@. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/PageAnimator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index c111f2c4bd18fec240b84fd55b0b9862c15f6f04..076cc6d46d7050c0368170909755e829ad3c5492 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -2788,8 +2788,14 @@ void FrameView::updateLayoutAndStyleForPainting()
RefPtr<FrameView> protector(this);
updateLayoutAndStyleIfNeededRecursive();
- if (RenderView* view = renderView())
+ if (RenderView* view = renderView()) {
+ ASSERT(!view->needsLayout());
view->compositor()->updateCompositingLayers();
+
+ // FIXME: we should not have any dirty bits left at this point. Unfortunately, this is not yet the case because
+ // the code in updateCompositingLayers sometimes creates new dirty bits when updating direct compositing reasons.
+ view->compositor()->scheduleAnimationIfNeeded();
abarth-chromium 2014/03/19 18:26:11 Would you be willing to file a bug on this topic?
chrishtr 2014/03/19 18:31:14 Done.
+ }
}
void FrameView::updateLayoutAndStyleIfNeededRecursive()
« no previous file with comments | « no previous file | Source/core/page/PageAnimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698