Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 202533003: Don't schedule an animation during compositing dirty-bit setting unless needed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Cleanup. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index bb0492541323368e4641aef3a4acc42f7ba7b61b..09c851b53ac02caece93d85a83ada1998d07e330 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -2784,8 +2784,14 @@ void FrameView::updateLayoutAndStyleForPainting()
RefPtr<FrameView> protector(this);
updateLayoutAndStyleIfNeededRecursive();
- if (RenderView* view = renderView())
+ if (RenderView* view = renderView()) {
+ ASSERT(!view->needsLayout());
view->compositor()->updateCompositingLayers();
+
+ // FIXME: we should not have any dirty bits left at this point. Unfortunately, this is not yet the case because
+ // the code in updateCompositingLayers sometimes creates new dirty bits when updating direct compositing reasons.
+ view->compositor()->scheduleAnimationIfNeeded();
+ }
}
void FrameView::updateLayoutAndStyleIfNeededRecursive()
« no previous file with comments | « no previous file | Source/core/page/PageAnimator.h » ('j') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698