Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2025233003: Rename ClassElementImpl and its subclasses. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -223 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 8 chunks +186 lines, -185 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 2 chunks +3 lines, -3 lines 1 comment Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 6 months ago (2016-06-01 18:25:44 UTC) #1
Paul Berry
lgtm
4 years, 6 months ago (2016-06-01 18:28:33 UTC) #2
Brian Wilkerson
Aside from the fact that this is a breaking change, as discussed before, lgtm. https://codereview.chromium.org/2025233003/diff/1/pkg/analyzer/lib/src/task/strong_mode.dart ...
4 years, 6 months ago (2016-06-01 18:41:40 UTC) #3
scheglov
4 years, 6 months ago (2016-06-01 19:41:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
554df80cd719b34562973e900c9b414a13b8c560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698