Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

Issue 202523011: Add a function to create a bookmark app from a WebApplicationInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_tab_helper
Patch Set: fix the fix Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
index ec96d23c5f204a95b2ef6e6d6493661cc6ce0a52..b6c32eb892f889075febc49ec18dc618cbee01c6 100644
--- a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
@@ -7,7 +7,8 @@
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/extensions/app_icon_loader_impl.h"
-#include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/bookmark_app_helper.h"
+#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h"
#include "extensions/browser/pref_names.h"
@@ -257,8 +258,6 @@ void BookmarkAppBubbleView::ApplyEdits() {
WebApplicationInfo install_info(web_app_info_);
install_info.title = title_tf_->text();
- scoped_refptr<extensions::CrxInstaller> installer(
- extensions::CrxInstaller::CreateSilent(profile_->GetExtensionService()));
- installer->set_error_on_unsupported_requirements(true);
- installer->InstallWebApp(install_info);
+ extensions::CreateOrUpdateBookmarkApp(profile_->GetExtensionService(),
+ install_info);
}
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698