Fully update compositing information for *layerTreeAsText calls

Fully update compositing information for *layerTreeAsText calls

This patch ensures the compositing layers are up-to-date
when calling elementLayerTreeAsText and layerTreeAsText
from tests. Before, elementLayerTreeAsText had a
DisableCompositingQueryAsserts which this patch removes.
layerTreeAsText previously updated updateCompositingLayers
but that was not sufficient; this patch adds a tighter
assert and calls updateLayoutAndStyleForPainting to fully
update.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169579

[pdr., 2014-03-18 21:07:38]

ping

[pdr., 2014-03-18 21:07:39]

ping

[eseidel, 2014-03-18 21:14:35]

https://codereview.chromium.org/202523004/diff/1/Source/core/frame/LocalFrame...
File Source/core/frame/LocalFrame.cpp (left):

https://codereview.chromium.org/202523004/diff/1/Source/core/frame/LocalFrame...
Source/core/frame/LocalFrame.cpp:426: String
LocalFrame::layerTreeAsText(unsigned flags) const
Should this ASSERT that it's up to date?

[eseidel, 2014-03-18 21:14:58]

jamesr is probably your best reviewer.

[ojan, 2014-03-19 17:29:41]

lgtm

https://codereview.chromium.org/202523004/diff/1/Source/core/frame/LocalFrame...
File Source/core/frame/LocalFrame.cpp (left):

https://codereview.chromium.org/202523004/diff/1/Source/core/frame/LocalFrame...
Source/core/frame/LocalFrame.cpp:426: String
LocalFrame::layerTreeAsText(unsigned flags) const
On 2014/03/18 21:14:35, eseidel wrote:
> Should this ASSERT that it's up to date?

The layerTreeAsText call on line 431 asserts this. It wouldn't hurt to have the
assert here as well since contentRenderer probably needs style to be up to date.

[pdr., 2014-03-19 17:43:22]

On 2014/03/19 17:29:41, ojan wrote:
> lgtm
> 
>
https://codereview.chromium.org/202523004/diff/1/Source/core/frame/LocalFrame...
> File Source/core/frame/LocalFrame.cpp (left):
> 
>
https://codereview.chromium.org/202523004/diff/1/Source/core/frame/LocalFrame...
> Source/core/frame/LocalFrame.cpp:426: String
> LocalFrame::layerTreeAsText(unsigned flags) const
> On 2014/03/18 21:14:35, eseidel wrote:
> > Should this ASSERT that it's up to date?
> 
> The layerTreeAsText call on line 431 asserts this. It wouldn't hurt to have
the
> assert here as well since contentRenderer probably needs style to be up to
date.

Thanks for the reviews. I've added an assert that the compositor state is up to
date in layerTreeAsText.

Off to the CQ

[pdr., 2014-03-19 17:43:25]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-19 17:43:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/202523004/20001

[commit-bot: I haz the power, 2014-03-19 18:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 18:49:04]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[pdr., 2014-03-19 19:30:07]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-03-19 19:30:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/202523004/20001

[commit-bot: I haz the power, 2014-03-19 20:16:54]

Change committed as 169579