Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2025213002: Remove id attribute from PaymentItem in test. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove id attribute from PaymentItem in test. PaymentItem no longer has an 'id' attribute. This patch removes the 'id' attribute from one of the last places in the code base. This place was missed in the patch that originally introduced the change. BUG=587995 Committed: https://crrev.com/16a031ebcd38ec010bb3148f4aec24bc23b90063 Cr-Commit-Position: refs/heads/master@{#397026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
please use gerrit instead
mek@, ptal.
4 years, 6 months ago (2016-06-01 00:46:57 UTC) #2
Marijn Kruisselbrink
lgtm
4 years, 6 months ago (2016-06-01 00:48:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025213002/1
4 years, 6 months ago (2016-06-01 00:49:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 02:21:46 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 02:23:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16a031ebcd38ec010bb3148f4aec24bc23b90063
Cr-Commit-Position: refs/heads/master@{#397026}

Powered by Google App Engine
This is Rietveld 408576698