Track shared isolates better in FXJSE.

fpdfsdk/fpdfxfa/fpdfxfa_app.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_app.h"
 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h"
 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_util.h"
 #include "fpdfsdk/include/fsdk_define.h"
@@ skipping 14 matching lines @@
 
 void CPDFXFA_App::ReleaseInstance() {
   delete g_pApp;
   g_pApp = NULL;
 }
 
 CPDFXFA_App::CPDFXFA_App()
     : m_bJavaScriptInitialized(FALSE),
       m_pXFAApp(NULL),
       m_pIsolate(nullptr),
-      m_csAppType(JS_STR_VIEWERTYPE_STANDARD),
-      m_bOwnedRuntime(false) {
+      m_csAppType(JS_STR_VIEWERTYPE_STANDARD) {
   m_pEnvList.RemoveAll();
 }
 
 CPDFXFA_App::~CPDFXFA_App() {
   delete m_pXFAApp;
   m_pXFAApp = NULL;
 
-#ifdef PDF_ENABLE_XFA
-  FXJSE_Runtime_Release(m_pIsolate, m_bOwnedRuntime);
+  FXJSE_Runtime_Release(m_pIsolate);
   m_pIsolate = nullptr;
 
   FXJSE_Finalize();
   BC_Library_Destory();
-#endif
 }
 
 FX_BOOL CPDFXFA_App::Initialize(v8::Isolate* pIsolate) {
-#ifdef PDF_ENABLE_XFA
   BC_Library_Init();
   FXJSE_Initialize();
 
-  m_bOwnedRuntime = !pIsolate;
-  m_pIsolate = pIsolate ? pIsolate : FXJSE_Runtime_Create();
+  m_pIsolate = pIsolate ? pIsolate : FXJSE_Runtime_Create_Own();
   if (!m_pIsolate)
     return FALSE;
 
   m_pXFAApp = new CXFA_FFApp(this);
   m_pXFAApp->SetDefaultFontMgr(
       std::unique_ptr<CXFA_DefFontMgr>(new CXFA_DefFontMgr));
-#endif
+
   return TRUE;
 }
 
 FX_BOOL CPDFXFA_App::AddFormFillEnv(CPDFDoc_Environment* pEnv) {
   if (!pEnv)
     return FALSE;
 
   m_pEnvList.Add(pEnv);
   return TRUE;
 }
@@ skipping 434 matching lines @@
   }
 }
 
 IFWL_AdapterTimerMgr* CPDFXFA_App::GetTimerMgr() {
   CXFA_FWLAdapterTimerMgr* pAdapter = NULL;
   CPDFDoc_Environment* pEnv = m_pEnvList.GetAt(0);
   if (pEnv)
     pAdapter = new CXFA_FWLAdapterTimerMgr(pEnv);
   return pAdapter;
 }