Track shared isolates better in FXJSE.

Track shared isolates better in FXJSE.

Fix the asymmetry between creating only some isolates and
releasing all of them, even the shared ones, by being more
careful not to trash those we didn't create.

Committed: https://pdfium.googlesource.com/pdfium/+/d5f726188761cd00cb3d16921093a859bda39a71

[Tom Sepez, 2016-06-01 00:06:13]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-06-01 00:06:13]

Dan for review.

[Tom Sepez, 2016-06-01 00:07:34]

Description was changed from

==========
Track shared isolates better in FXJSE.
==========

to

==========
Track shared isolates better in FXJSE.

Fix the asymmetry between creating some isolates and releasing all
of them, even the shared ones by being more careful not
to trash
those we didn't create.
==========

[Tom Sepez, 2016-06-01 00:09:25]

Description was changed from

==========
Track shared isolates better in FXJSE.

Fix the asymmetry between creating some isolates and releasing all
of them, even the shared ones by being more careful not
to trash
those we didn't create.
==========

to

==========
Track shared isolates better in FXJSE.

Fix the asymmetry between creating only some isolates and
releasing all of them, even the shared ones, by being more
careful not to trash those we didn't create.
==========

[dsinclair, 2016-06-01 02:57:36]

lgtm w/ nits.

https://codereview.chromium.org/2025193002/diff/20001/xfa/fxjse/runtime.cpp
File xfa/fxjse/runtime.cpp (right):

https://codereview.chromium.org/2025193002/diff/20001/xfa/fxjse/runtime.cpp#n...
xfa/fxjse/runtime.cpp:51: if (CFXJSE_IsolateTracker::g_pInstance) {
if (!CFXJSE_IsolateTracker::g_pInstance)
  return;

https://codereview.chromium.org/2025193002/diff/20001/xfa/fxjse/runtime.cpp#n...
xfa/fxjse/runtime.cpp:55: CFXJSE_IsolateTracker::g_pInstance = NULL;
nit: nullptr

[Tom Sepez, 2016-06-01 20:48:19]

https://codereview.chromium.org/2025193002/diff/20001/xfa/fxjse/runtime.cpp
File xfa/fxjse/runtime.cpp (right):

https://codereview.chromium.org/2025193002/diff/20001/xfa/fxjse/runtime.cpp#n...
xfa/fxjse/runtime.cpp:51: if (CFXJSE_IsolateTracker::g_pInstance) {
On 2016/06/01 02:57:36, dsinclair wrote:
> if (!CFXJSE_IsolateTracker::g_pInstance)
>   return;

Done.

https://codereview.chromium.org/2025193002/diff/20001/xfa/fxjse/runtime.cpp#n...
xfa/fxjse/runtime.cpp:55: CFXJSE_IsolateTracker::g_pInstance = NULL;
On 2016/06/01 02:57:36, dsinclair wrote:
> nit: nullptr

Done.

[Tom Sepez, 2016-06-01 20:49:19]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-06-01 20:49:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2025193002/#ps60001
(title: "Nits.")

[commit-bot: I haz the power, 2016-06-01 20:49:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025193002/60001

[commit-bot: I haz the power, 2016-06-01 21:01:34]

Description was changed from

==========
Track shared isolates better in FXJSE.

Fix the asymmetry between creating only some isolates and
releasing all of them, even the shared ones, by being more
careful not to trash those we didn't create.
==========

to

==========
Track shared isolates better in FXJSE.

Fix the asymmetry between creating only some isolates and
releasing all of them, even the shared ones, by being more
careful not to trash those we didn't create.

Committed:
https://pdfium.googlesource.com/pdfium/+/d5f726188761cd00cb3d16921093a859bda3...
==========

[commit-bot: I haz the power, 2016-06-01 21:01:35]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/d5f726188761cd00cb3d16921093a859bda3...