Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2025153002: Remove NTP Favicon flag. (Closed)

Created:
4 years, 6 months ago by michaeldo
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NTP Favicon flag. BUG=none Committed: https://crrev.com/b561a3fa7934f333ce9455a0ea16ccb905bb01fe Cr-Commit-Position: refs/heads/master@{#397826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M ios/chrome/browser/about_flags.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
michaeldo
4 years, 6 months ago (2016-05-31 22:11:39 UTC) #2
rohitrao (ping after 24h)
LGTM but I think this will need to wait until after your other CL lands
4 years, 6 months ago (2016-05-31 23:05:43 UTC) #3
michaeldo
On 2016/05/31 23:05:43, rohitrao (OOO until June) wrote: > LGTM but I think this will ...
4 years, 6 months ago (2016-05-31 23:56:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025153002/1
4 years, 6 months ago (2016-06-03 21:02:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 22:39:56 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 22:41:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b561a3fa7934f333ce9455a0ea16ccb905bb01fe
Cr-Commit-Position: refs/heads/master@{#397826}

Powered by Google App Engine
This is Rietveld 408576698