third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h - Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h

Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h

index d8c6b81f80a026a65d21153753168502b8220427..257bc58b0b31a3f06a5fb12a4efd819ddcf75cd1 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h

@@ -26,8 +26,8 @@ class MODULES_EXPORT ForeignFetchEvent final : public ExtendableEvent {

DEFINE_WRAPPERTYPEINFO();

public:

static ForeignFetchEvent* create();

- static ForeignFetchEvent* create(const AtomicString& type, const ForeignFetchEventInit&);

- static ForeignFetchEvent* create(const AtomicString& type, const ForeignFetchEventInit&, ForeignFetchRespondWithObserver*);

+ static ForeignFetchEvent* create(ScriptState*, const AtomicString& type, const ForeignFetchEventInit&);

+ static ForeignFetchEvent* create(ScriptState*, const AtomicString& type, const ForeignFetchEventInit&, ForeignFetchRespondWithObserver*);

Request* request() const;

String origin() const;

@@ -40,7 +40,7 @@ public:

protected:

ForeignFetchEvent();

- ForeignFetchEvent(const AtomicString& type, const ForeignFetchEventInit&, ForeignFetchRespondWithObserver*);

+ ForeignFetchEvent(ScriptState*, const AtomicString& type, const ForeignFetchEventInit&, ForeignFetchRespondWithObserver*);

private:

Member<ForeignFetchRespondWithObserver> m_observer;