third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h - Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h

Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h ('k') | third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h

index 20086b2a2db69db5e8e58f8f1b9eb8b786aa26c0..57dd18156669b07a85e8251fd6d32ca622e81a62 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h

@@ -27,8 +27,8 @@ class MODULES_EXPORT FetchEvent final : public ExtendableEvent {

DEFINE_WRAPPERTYPEINFO();

public:

static FetchEvent* create();

- static FetchEvent* create(const AtomicString& type, const FetchEventInit&);

- static FetchEvent* create(const AtomicString& type, const FetchEventInit&, RespondWithObserver*);

+ static FetchEvent* create(ScriptState*, const AtomicString& type, const FetchEventInit&);

+ static FetchEvent* create(ScriptState*, const AtomicString& type, const FetchEventInit&, RespondWithObserver*);

Request* request() const;

String clientId() const;

@@ -42,7 +42,7 @@ public:

protected:

FetchEvent();

- FetchEvent(const AtomicString& type, const FetchEventInit&, RespondWithObserver*);

+ FetchEvent(ScriptState*, const AtomicString& type, const FetchEventInit&, RespondWithObserver*);

private:

Member<RespondWithObserver> m_observer;