third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html - Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

similarity index 63%

copy from third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html

copy to third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

index ee22c7fab5a5682a2087b429adf2c9e141275400..481ddf318af5f4824f7fa9cd8f9264d79f4cce20 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/fetch-request-with-gc.html

@@ -1,14 +1,18 @@

<!DOCTYPE html>

-<title>Service Worker: CORS XHR of fetch()</title>

-<script src="../resources/testharness.js"></script>

-<script src="../resources/testharnessreport.js"></script>

-<script src="../resources/get-host-info.js?pipe=sub"></script>

-<script src="resources/test-helpers.js"></script>

+<title>Service Worker: fetch(e.request) with GC</title>

+<script src="../..//resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/get-host-info.js?pipe=sub"></script>

+<script src="../resources/test-helpers.js"></script>

<body>

+<!--

+This test is placed on chromium/directory because it tests very blink specific

+problems related to V8 and bindings.

+-->

async_test(function(t) {

- var SCOPE = 'resources/fetch-cors-xhr-iframe.html';

- var SCRIPT = 'resources/fetch-rewrite-worker.js';

+ var SCOPE = 'resources/fetch-request-with-gc-iframe.html';

+ var SCRIPT = 'resources/fetch-request-with-gc.js';

var host_info = get_host_info();

@@ -33,6 +37,6 @@ async_test(function(t) {

});

})

.catch(unreached_rejection(t));

- }, 'Verify CORS XHR of fetch() in a Service Worker');

+ }, 'Calling gc and delaying calling fetch in onFetch should not lead to crash');

</script>

</body>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js » ('j') | no next file with comments »