third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc-iframe.html - Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc-iframe.html

Issue 2025143003: [Fetch API] Request's JS wrapper should be kept alive in FetchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/fetch-request-with-gc.js ('k') | third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h » ('j') | third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../../resources/get-host-info.js?pipe=sub"></script>

	3 <script src="../../resources/test-helpers.js"></script>

	4 <script>

	5 window.addEventListener('message', event => {

	6 const port = event.ports[0];

	7 const url = get_host_info()['HTTP_ORIGIN'] + base_path();
	falken 2016/06/02 08:36:31 do you need the get_host_info stuff? can it just b do you need the get_host_info stuff? can it just be fetch(base_path())? yhirano 2016/06/02 10:10:11 Done. Show quoted text On 2016/06/02 08:36:31, falken wrote: > do you need the get_host_info stuff? can it just be fetch(base_path())? Done.
	8 fetch(url, {method: 'POST', body: 'hello'})

	9 .then(() => port.postMessage({results: 'finish'}))

	10 .catch(e => port.postMessage({results: 'failure:' + e}));

	11 });

	12 </script>

OLD	NEW