Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2025133002: mac: Remove a workaround that's no longer needed. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove a workaround that's no longer needed. This reverts https://codereview.chromium.org/7655040 We don't use ATS any more, and we don't support OS X 10.7 any more. BUG=93191, 579255 TBR=avi Committed: https://crrev.com/59d93bcaffafae8bf3efc5ffad4dd3c9112ee6c9 Cr-Commit-Position: refs/heads/master@{#396953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -41 lines) Patch
M chrome/app/framework.order View 1 chunk +2 lines, -5 lines 0 comments Download
M content/common/mac/font_loader.mm View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Nico
I tried the TEST= steps from your old CL.
4 years, 6 months ago (2016-05-31 21:20:51 UTC) #2
Mark Mentovai
LGTM
4 years, 6 months ago (2016-05-31 21:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025133002/1
4 years, 6 months ago (2016-05-31 21:54:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/192447)
4 years, 6 months ago (2016-05-31 22:03:55 UTC) #8
Nico
tbr avi for content/owners
4 years, 6 months ago (2016-05-31 22:08:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025133002/1
4 years, 6 months ago (2016-05-31 22:09:20 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 22:26:19 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/59d93bcaffafae8bf3efc5ffad4dd3c9112ee6c9 Cr-Commit-Position: refs/heads/master@{#396953}
4 years, 6 months ago (2016-05-31 22:27:48 UTC) #17
Avi (use Gerrit)
4 years, 6 months ago (2016-06-01 03:05:06 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698