Use better fallback URLs when calling AVScanFile().

content/browser/download/quarantine_win_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/quarantine.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/test/histogram_tester.h"
 #include "net/base/filename_util.h"
@@ skipping 23 matching lines @@
             QuarantineFile(test_dir.path().AppendASCII("does-not-exist.exe"),
                            GURL(kDummySourceUrl), GURL(kDummyReferrerUrl),
                            kDummyClientGuid));
 }
 
 // On Windows systems, files downloaded from a local source are considered
 // trustworthy. Hence they aren't annotated with source information. This test
 // verifies this behavior since the other tests in this suite would pass with a
 // false positive if local files are being annotated with the MOTW for the
 // internet zone.
-TEST(QuarantineWinTest, LocalFileZoneAssumption_DependsOnLocalConfig) {
+TEST(QuarantineWinTest, LocalFile_DependsOnLocalConfig) {
   base::HistogramTester histogram_tester;
   base::ScopedTempDir test_dir;
   ASSERT_TRUE(test_dir.CreateUniqueTempDir());
   base::FilePath test_file = test_dir.path().AppendASCII("foo.exe");
-  ASSERT_EQ(5, base::WriteFile(test_file, "Hello", 5u));
 
-  EXPECT_EQ(QuarantineFileResult::OK,
-            QuarantineFile(test_file, net::FilePathToFileURL(test_file), GURL(),
-                           kDummyClientGuid));
-  std::string contents;
-  EXPECT_FALSE(base::ReadFileToString(
-      base::FilePath(test_file.value() + kMotwStreamSuffix), &contents));
+  const char* const kLocalSourceURLs[] = {
+    "http://localhost/foo",
+    "data:text/plain,Foobar",
+    "data:application/octet-stream,Foobar",
+    "file:///some-local-dir/foo.exe"
+  };
+
+  for (const auto source_url : kLocalSourceURLs) {
+    SCOPED_TRACE(::testing::Message() << "Trying URL " << source_url);
+    ASSERT_EQ(5, base::WriteFile(test_file, "Hello", 5u));
+
+    EXPECT_EQ(
+        QuarantineFileResult::OK,
+        QuarantineFile(test_file, GURL(source_url), GURL(), kDummyClientGuid));
+
+    std::string contents;
+    base::ReadFileToString(
+        base::FilePath(test_file.value() + kMotwStreamSuffix), &contents);
+
+    // These warnings aren't displayed on successful test runs. They are there
+    // so that we can check for deviations in behavior during manual testing.
+    if (!contents.empty()) {
+      LOG(WARNING) << "Unexpected zone marker for file " << test_file.value()
+                   << " Source URL:" << source_url;
+      if (contents != kMotwForInternetZone)
+        LOG(WARNING) << "Zone marker contents: " << contents;
+    }
+
+    base::DeleteFile(test_file, false);
+  }
 
   // Bucket 1 is SUCCESS_WITHOUT_MOTW.
   histogram_tester.ExpectUniqueSample("Download.AttachmentServices.Result", 1,
-                                      1);
+                                      arraysize(kLocalSourceURLs));
 }
 
 // A file downloaded from the internet should be annotated with .. something.
 // The specific zone assigned to our dummy source URL depends on the local
 // configuration. But no sane configuration should be treating the dummy URL as
 // a trusted source for anything.
 TEST(QuarantineWinTest, DownloadedFile_DependsOnLocalConfig) {
   base::HistogramTester histogram_tester;
   base::ScopedTempDir test_dir;
   ASSERT_TRUE(test_dir.CreateUniqueTempDir());
   base::FilePath test_file = test_dir.path().AppendASCII("foo.exe");
+
+  const char* const kUnsafeSourceURLs[] = {
+    "http://example.com/foo",
+    "https://exmaple.com/foo",

[elawrence, 2016/08/02 21:09:22]

I *think* "exmaple" is a harmless typo, but maybe fix it to reduce ambiguity.

[asanka, 2016/09/23 01:34:53]

Fixed :)

+    "ftp://example.com/foo",
+    "ftp://example.com:2121/foo",
+    "about:internet",
+    ""
+  };
+
+  for (const auto source_url : kUnsafeSourceURLs) {
+    SCOPED_TRACE(::testing::Message() << "Trying URL " << source_url);
+    ASSERT_EQ(5, base::WriteFile(test_file, "Hello", 5u));
+    EXPECT_EQ(
+        QuarantineFileResult::OK,
+        QuarantineFile(test_file, GURL(source_url), GURL(), kDummyClientGuid));
+    std::string contents;
+    ASSERT_TRUE(base::ReadFileToString(
+        base::FilePath(test_file.value() + kMotwStreamSuffix), &contents));
+    // The actual assigned zone could be anything. So only testing that there is
+    // a zone annotation.
+    EXPECT_FALSE(contents.empty());
+
+    // These warnings aren't displayed on successful test runs. They are there
+    // so that we can check for deviations in behavior during manual testing.
+    if (contents != kMotwForInternetZone)
+      LOG(WARNING) << "Unexpected zone marker: " << contents;
+    base::DeleteFile(test_file, false);
+  }
+
+  // Bucket 0 is SUCCESS_WITH_MOTW.
+  histogram_tester.ExpectUniqueSample("Download.AttachmentServices.Result", 0,
+                                      arraysize(kUnsafeSourceURLs));
+}
+
+// An empty source URL should result in a file that's treated the same as one
+// downloaded from the internet.
+TEST(QuarantineWinTest, EmptySource_DependsOnLocalConfig) {
+  base::HistogramTester histogram_tester;
+  base::ScopedTempDir test_dir;
+  ASSERT_TRUE(test_dir.CreateUniqueTempDir());
+  base::FilePath test_file = test_dir.path().AppendASCII("foo.exe");
   ASSERT_EQ(5, base::WriteFile(test_file, "Hello", 5u));
 
   EXPECT_EQ(QuarantineFileResult::OK,
-            QuarantineFile(test_file, GURL(kDummySourceUrl),
-                           GURL(kDummyReferrerUrl), kDummyClientGuid));
+            QuarantineFile(test_file, GURL(), GURL(), kDummyClientGuid));
   std::string contents;
   ASSERT_TRUE(base::ReadFileToString(
       base::FilePath(test_file.value() + kMotwStreamSuffix), &contents));
   // The actual assigned zone could be anything. So only testing that there is a
   // zone annotation.
   EXPECT_FALSE(contents.empty());
 
   // Bucket 0 is SUCCESS_WITH_MOTW.
   histogram_tester.ExpectUniqueSample("Download.AttachmentServices.Result", 0,
                                       1);
@@ skipping 30 matching lines @@
   EXPECT_EQ(QuarantineFileResult::OK,
             QuarantineFile(test_file, net::FilePathToFileURL(test_file), GURL(),
                            std::string()));
   std::string contents;
   ASSERT_TRUE(base::ReadFileToString(
       base::FilePath(test_file.value() + kMotwStreamSuffix), &contents));
   EXPECT_STREQ(kMotwForInternetZone, contents.c_str());
 }
 
 }  // content