Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2025083002: Version 5.1.281.58 (cherry-pick) (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.58 (cherry-pick) Merged 141bc11 Merged 60c0389 S390: Fix storing to below stack to avoid sampler handler corrupting stored value (again) Note: Some changes weren't melt into 5.1 last time. S390: Fix Macro-Asm DCHECK R=hablich@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -60 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 3 chunks +20 lines, -26 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 8 chunks +8 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
john.yan
4 years, 6 months ago (2016-05-31 19:38:36 UTC) #1
Michael Hablich
rubberstamp lgtm
4 years, 6 months ago (2016-06-01 14:51:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025083002/1
4 years, 6 months ago (2016-06-01 15:02:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 15:02:44 UTC) #8
john.yan
4 years, 6 months ago (2016-06-01 15:03:44 UTC) #9
Message was sent while issue was closed.
On 2016/06/01 14:51:59, Hablich wrote:
> rubberstamp lgtm

Thank you!

Powered by Google App Engine
This is Rietveld 408576698