Promises: Make PromiseSet operation monomorphic

Promises: Make PromiseSet operation monomorphic

The PromiseSet operation is called with two types of promises
1) A newly created promise object with no properties
2) Promise object with callbacks and other properties

PromiseSet is called with the first type of promise (with no
properties) from multiple call sites. PromiseSet is called with the
second type of promise object only from FulfillPromise. Furthermore,
this call only sets the value and status of the promise, the rest of
the values are reset to UNDEFINED (which isn't necessary).

This patch inlines the calls to set the value and status of the
promise in FulfillPromise, instead of calling out to PromiseSet.

This patch also reduces the number of symbol lookups, as we only set
the value and status of the promise, and don't change the callback or
deferred symbols.

This patch results in a performance improvement of 2.8% over 5 runs in
the bluebird benchmark.

BUG=v8:5046
Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
Cr-Commit-Position: refs/heads/master@{#36688}

[gsathya, 2016-05-31 19:23:14]

Description was changed from

==========
Promises: Make PromiseSet operation monomorphic

The PromiseSet operation is called with two types of promises
1) A newly created promise object with no properties
2) Promise object with callbacks and other properties

PromiseSet is called with the first type of promise (with no
properties) from multiple call sites. PromiseSet is called with the
second type of promise object only from FulfillPromise. Furthermore,
this call only sets the value and status of the promise, the rest of
the values are reset to UNDEFINED (which isn't necessary).

This patch inlines the calls to set the value and status of the
promise in FulfillPromise, instead of calling out to PromiseSet.

This patch results in a performance improvement of 2.8% over 5 runs in
the bluebird benchmark.

BUG=v8:5046
==========

to

==========
Promises: Make PromiseSet operation monomorphic

The PromiseSet operation is called with two types of promises
1) A newly created promise object with no properties
2) Promise object with callbacks and other properties

PromiseSet is called with the first type of promise (with no
properties) from multiple call sites. PromiseSet is called with the
second type of promise object only from FulfillPromise. Furthermore,
this call only sets the value and status of the promise, the rest of
the values are reset to UNDEFINED (which isn't necessary).

This patch inlines the calls to set the value and status of the
promise in FulfillPromise, instead of calling out to PromiseSet.

This patch also reduces the number of symbol lookups, as we only set 
the value and status of the promise, and don't change the callback or 
deferred symbols.

This patch results in a performance improvement of 2.8% over 5 runs in
the bluebird benchmark.

BUG=v8:5046
==========

[gsathya, 2016-05-31 19:23:29]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 19:23:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025073002/1

[commit-bot: I haz the power, 2016-05-31 19:47:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 19:47:48]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-05-31 20:10:11]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org, littledan@chromium.org

[Dan Ehrenberg, 2016-06-01 15:26:34]

lgtm

Seems good to me. If we face a lot of different maps flowing through the Promise
code in general, that seems to be an argument for rewriting the core of the
Promise code in C++.

[gsathya, 2016-06-02 16:17:10]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2016-06-02 16:17:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025073002/1

[commit-bot: I haz the power, 2016-06-02 16:42:19]

Description was changed from

==========
Promises: Make PromiseSet operation monomorphic

The PromiseSet operation is called with two types of promises
1) A newly created promise object with no properties
2) Promise object with callbacks and other properties

PromiseSet is called with the first type of promise (with no
properties) from multiple call sites. PromiseSet is called with the
second type of promise object only from FulfillPromise. Furthermore,
this call only sets the value and status of the promise, the rest of
the values are reset to UNDEFINED (which isn't necessary).

This patch inlines the calls to set the value and status of the
promise in FulfillPromise, instead of calling out to PromiseSet.

This patch also reduces the number of symbol lookups, as we only set 
the value and status of the promise, and don't change the callback or 
deferred symbols.

This patch results in a performance improvement of 2.8% over 5 runs in
the bluebird benchmark.

BUG=v8:5046
==========

to

==========
Promises: Make PromiseSet operation monomorphic

The PromiseSet operation is called with two types of promises
1) A newly created promise object with no properties
2) Promise object with callbacks and other properties

PromiseSet is called with the first type of promise (with no
properties) from multiple call sites. PromiseSet is called with the
second type of promise object only from FulfillPromise. Furthermore,
this call only sets the value and status of the promise, the rest of
the values are reset to UNDEFINED (which isn't necessary).

This patch inlines the calls to set the value and status of the
promise in FulfillPromise, instead of calling out to PromiseSet.

This patch also reduces the number of symbol lookups, as we only set 
the value and status of the promise, and don't change the callback or 
deferred symbols.

This patch results in a performance improvement of 2.8% over 5 runs in
the bluebird benchmark.

BUG=v8:5046
==========

[commit-bot: I haz the power, 2016-06-02 16:42:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-02 16:43:58]

Description was changed from

==========
Promises: Make PromiseSet operation monomorphic

The PromiseSet operation is called with two types of promises
1) A newly created promise object with no properties
2) Promise object with callbacks and other properties

PromiseSet is called with the first type of promise (with no
properties) from multiple call sites. PromiseSet is called with the
second type of promise object only from FulfillPromise. Furthermore,
this call only sets the value and status of the promise, the rest of
the values are reset to UNDEFINED (which isn't necessary).

This patch inlines the calls to set the value and status of the
promise in FulfillPromise, instead of calling out to PromiseSet.

This patch also reduces the number of symbol lookups, as we only set 
the value and status of the promise, and don't change the callback or 
deferred symbols.

This patch results in a performance improvement of 2.8% over 5 runs in
the bluebird benchmark.

BUG=v8:5046
==========

to

==========
Promises: Make PromiseSet operation monomorphic

The PromiseSet operation is called with two types of promises
1) A newly created promise object with no properties
2) Promise object with callbacks and other properties

PromiseSet is called with the first type of promise (with no
properties) from multiple call sites. PromiseSet is called with the
second type of promise object only from FulfillPromise. Furthermore,
this call only sets the value and status of the promise, the rest of
the values are reset to UNDEFINED (which isn't necessary).

This patch inlines the calls to set the value and status of the
promise in FulfillPromise, instead of calling out to PromiseSet.

This patch also reduces the number of symbol lookups, as we only set
the value and status of the promise, and don't change the callback or
deferred symbols.

This patch results in a performance improvement of 2.8% over 5 runs in
the bluebird benchmark.

BUG=v8:5046

Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
Cr-Commit-Position: refs/heads/master@{#36688}
==========

[commit-bot: I haz the power, 2016-06-02 16:43:59]

Patchset 1 (id:??) landed as
https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
Cr-Commit-Position: refs/heads/master@{#36688}

[gsathya, 2016-06-06 21:18:03]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2047553002/ by gsathya@chromium.org.

The reason for reverting is: As a side effect of calling PromiseSet from 
FulfillPromise, clears the deferred symbol and the 
resolve/reject callback symbols. Although this 
isn't strictly necessary, not doing this seems to 
result in a leak as seen in --

https://bugs.chromium.org/p/chromium/issues/detail?id=617137#c10.