Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2025053002: Mojo C++ bindings: fix a DCHECK in multiplex_router.h (Closed)

Created:
4 years, 6 months ago by yzshen1
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: fix a DCHECK in multiplex_router.h BUG=None Committed: https://crrev.com/542452b027f688a5a02070dcc41ed7fcc9d057b8 Cr-Commit-Position: refs/heads/master@{#396903}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 6 months ago (2016-05-31 18:50:38 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-05-31 18:56:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025053002/20001
4 years, 6 months ago (2016-05-31 19:35:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 20:00:40 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:44:49 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/542452b027f688a5a02070dcc41ed7fcc9d057b8
Cr-Commit-Position: refs/heads/master@{#396903}

Powered by Google App Engine
This is Rietveld 408576698