Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2025033002: Mojo C++ bindings: fix AssociatedInterfaceTest.MultiThreadAccess. (Closed)

Created:
4 years, 6 months ago by yzshen1
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: fix AssociatedInterfaceTest.MultiThreadAccess. In this test, each receiver receives values from two senders running in parallel. Previously, the test didn't wait for all data from both senders. BUG=615450 Committed: https://crrev.com/b27570bcea1c59859ca6690e0bcd1e3a8d7125c1 Cr-Commit-Position: refs/heads/master@{#396881}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 1 8 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 6 months ago (2016-05-31 18:02:54 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-05-31 18:08:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025033002/20001
4 years, 6 months ago (2016-05-31 18:10:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 19:01:17 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:02:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b27570bcea1c59859ca6690e0bcd1e3a8d7125c1
Cr-Commit-Position: refs/heads/master@{#396881}

Powered by Google App Engine
This is Rietveld 408576698