Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2025023003: MD Settings: closure compile the printing page (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: closure compile the printing page R=dschuyler@chromium.org BUG=602464 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOTRY=true Committed: https://crrev.com/bbf308a144b4f4026d86d9826756c0c563c6eae2 Cr-Commit-Position: refs/heads/master@{#397117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/settings/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/resources/settings/printing_page/compiled_resources2.gyp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Dan Beam
4 years, 6 months ago (2016-05-31 19:18:09 UTC) #2
dschuyler
lgtm
4 years, 6 months ago (2016-06-01 00:17:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025023003/1
4 years, 6 months ago (2016-06-01 12:54:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 12:58:00 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 12:59:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbf308a144b4f4026d86d9826756c0c563c6eae2
Cr-Commit-Position: refs/heads/master@{#397117}

Powered by Google App Engine
This is Rietveld 408576698