Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 2025003002: Refactor ManagePasswordsBubbleModel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index e7b2ddbe893b1999bbfdbe5bfa92288b91c766a8..9f22f7920d632ab43c55699aa1c620d1517fe020 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -53,11 +53,6 @@ enum UIDismissalReason {
AUTO_SIGNIN_TOAST_CLICKED_OBSOLETE, // obsolete.
CLICKED_BRAND_NAME,
NUM_UI_RESPONSES,
-
- // If we add the omnibox icon _without_ intending to display the bubble,
- // we actually call Close() after creating the bubble view. We don't want
- // that to count in the metrics, so we need this placeholder value.
- NOT_DISPLAYED
};
enum FormDeserializationStatus {
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698