components/password_manager/core/browser/password_manager_metrics_util.h - Issue 2025003002: Refactor ManagePasswordsBubbleModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 2025003002: Refactor ManagePasswordsBubbleModel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.h

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h

index e7b2ddbe893b1999bbfdbe5bfa92288b91c766a8..9f22f7920d632ab43c55699aa1c620d1517fe020 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.h

+++ b/components/password_manager/core/browser/password_manager_metrics_util.h

@@ -53,11 +53,6 @@ enum UIDismissalReason {

AUTO_SIGNIN_TOAST_CLICKED_OBSOLETE, // obsolete.

CLICKED_BRAND_NAME,

NUM_UI_RESPONSES,

- // If we add the omnibox icon _without_ intending to display the bubble,

- // we actually call Close() after creating the bubble view. We don't want

- // that to count in the metrics, so we need this placeholder value.

- NOT_DISPLAYED

};

enum FormDeserializationStatus {