AudioBus: Add a ToInterleavedFloat() method to AudioBus

content/renderer/media/audio_track_recorder.cc

Index: content/renderer/media/audio_track_recorder.cc
diff --git a/content/renderer/media/audio_track_recorder.cc b/content/renderer/media/audio_track_recorder.cc
index ad28b28d96b5ee3ae0d4015514ddbc5d296d23b4..0651ebbf35db34f457c58af0da8b0cf88f9794c4 100644
--- a/content/renderer/media/audio_track_recorder.cc
+++ b/content/renderer/media/audio_track_recorder.cc
@@ -76,19 +76,6 @@ bool DoEncode(OpusEncoder* opus_encoder,
   return false;
 }
 
-// Interleaves |audio_bus| channels() of floats into a single output linear
-// |buffer|.
-// TODO(mcasas) https://crbug.com/580391 use AudioBus::ToInterleavedFloat().
-void ToInterleaved(media::AudioBus* audio_bus, float* buffer) {
-  for (int ch = 0; ch < audio_bus->channels(); ++ch) {
-    const float* src = audio_bus->channel(ch);
-    const float* const src_end = src + audio_bus->frames();
-    float* dest = buffer + ch;
-    for (; src < src_end; ++src, dest += audio_bus->channels())
-      *dest = *src;
-  }
-}
-
 }  // anonymous namespace
 
 // Nested class encapsulating opus-related encoding details. It contains an
@@ -259,7 +246,8 @@ void AudioTrackRecorder::AudioEncoder::EncodeAudio(
     std::unique_ptr<media::AudioBus> audio_bus = media::AudioBus::Create(
         output_params_.channels(), kOpusPreferredFramesPerBuffer);
     converter_->Convert(audio_bus.get());
-    ToInterleaved(audio_bus.get(), buffer_.get());
+    audio_bus->ToInterleavedFloat(0, 0, audio_bus->frames(),
+                                  buffer_.get());

[mcasas, 2016/06/02 01:13:14]

Fits in one line?
    audio_bus->ToInterleavedFloat(0, 0, audio_bus->frames(), buffer_.get());

(Tip: run `git cl format` before uploading).

[chfremer, 2016/06/02 18:13:33]

Done.

 
     std::unique_ptr<std::string> encoded_data(new std::string());
     if (DoEncode(opus_encoder_, buffer_.get(), kOpusPreferredFramesPerBuffer,