chrome/browser/ui/browser.cc - Issue 2024953005: Allow app banners to be triggered by increases in site engagement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 2024953005: Allow app banners to be triggered by increases in site engagement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@site-engagement-callback

Patch Set: Address reviewer comments. Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index c038819ad1d3be11f2abc178996f7af219a7c0d3..b10b2df4a5f5698d7391adc35f1c5cbb2444ed59 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1352,8 +1352,7 @@ void Browser::RequestAppBannerFromDevTools(content::WebContents* web_contents) {

banners::AppBannerManagerEmulation::CreateForWebContents(web_contents);

banners::AppBannerManagerEmulation* manager =

banners::AppBannerManagerEmulation::FromWebContents(web_contents);

- manager->RequestAppBanner(web_contents->GetMainFrame(),

- web_contents->GetLastCommittedURL(), true);

+ manager->RequestAppBanner(web_contents->GetLastCommittedURL(), true);

}

bool Browser::IsMouseLocked() const {

« no previous file with comments | « chrome/browser/banners/app_banner_settings_helper_unittest.cc ('k') | no next file » | no next file with comments »