Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2024953005: Allow app banners to be triggered by increases in site engagement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@site-engagement-callback
Patch Set: Address reviewer comments. Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 697e9991872502b3cc071a32b77df0b51844a7f1..5556b543d17f8c9bbd6cef373ca76d9f5ff2808b 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -33,7 +33,7 @@ namespace banners {
AppBannerManagerAndroid::AppBannerManagerAndroid(
JNIEnv* env,
jobject obj)
- : AppBannerManager(),
+ : AppBannerManager(nullptr),
weak_java_banner_view_manager_(env, obj) {
}
@@ -185,9 +185,9 @@ bool AppBannerManagerAndroid::IsFetcherActive(
void AppBannerManagerAndroid::RequestAppBanner(
JNIEnv* env,
const JavaParamRef<jobject>& obj) {
- AppBannerManager::RequestAppBanner(web_contents()->GetMainFrame(),
- web_contents()->GetLastCommittedURL(),
- true);
+ // Set debug mode to true as this method is only called from DevTools.
+ AppBannerManager::RequestAppBanner(web_contents()->GetLastCommittedURL(),
+ true /* is_debug_mode */);
}
// static
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698