Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6139)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser.cc

Issue 2024953005: Allow app banners to be triggered by increases in site engagement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@site-engagement-callback
Patch Set: Remove obsolete test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/banners/app_banner_settings_helper.cc ('K') | « chrome/browser/banners/app_banner_settings_helper_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 64ab742dcf3ab7a1e8945781e1bf59d60556fb78..c942246bff8f6ac9ada965254422e781b9757496 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1347,8 +1347,7 @@ void Browser::RequestAppBannerFromDevTools(content::WebContents* web_contents) {
banners::AppBannerManagerEmulation::CreateForWebContents(web_contents);
banners::AppBannerManagerEmulation* manager =
banners::AppBannerManagerEmulation::FromWebContents(web_contents);
- manager->RequestAppBanner(web_contents->GetMainFrame(),
- web_contents->GetLastCommittedURL(), true);
+ manager->RequestAppBanner(web_contents->GetLastCommittedURL(), true);
}
bool Browser::IsMouseLocked() const {
« chrome/browser/banners/app_banner_settings_helper.cc ('K') | « chrome/browser/banners/app_banner_settings_helper_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698