Allow app banners to be triggered by increases in site engagement.

chrome/browser/banners/app_banner_settings_helper_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/engagement/site_engagement_service.h"
@@ skipping 758 matching lines @@
   EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
       web_contents(), url, kTestPackageName, fourth_day));
 
   // Visit the site again; now it should be shown.
   AppBannerSettingsHelper::RecordBannerCouldShowEvent(
       web_contents(), url, kTestPackageName, fifth_day,
       ui::PAGE_TRANSITION_TYPED);
   EXPECT_TRUE(AppBannerSettingsHelper::ShouldShowBanner(
       web_contents(), url, kTestPackageName, fifth_day));
 }
-
-// Test that the banner triggers correctly using site engagement.
-TEST_F(AppBannerSettingsHelperTest, SiteEngagementTrigger) {
-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kEnableSiteEngagementAppBanner);
-
-  SiteEngagementService* service = SiteEngagementService::Get(profile());
-  DCHECK(service);
-
-  // Not used, but needed for method call.
-  base::Time reference_time = GetReferenceTime();
-  GURL url(kTestURL);
-
-  EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
-      web_contents(), url, kTestPackageName, reference_time));
-
-  service->AddPoints(url, 1);
-  EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
-      web_contents(), url, kTestPackageName, reference_time));
-
-  service->AddPoints(url, 1);
-  EXPECT_TRUE(AppBannerSettingsHelper::ShouldShowBanner(
-      web_contents(), url, kTestPackageName, reference_time));
-
-  AppBannerSettingsHelper::SetTotalEngagementToTrigger(5);
-  EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
-      web_contents(), url, kTestPackageName, reference_time));
-
-  service->AddPoints(url, 1.5);
-  EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
-      web_contents(), url, kTestPackageName, reference_time));
-
-  service->AddPoints(url, 0.5);
-  EXPECT_FALSE(AppBannerSettingsHelper::ShouldShowBanner(
-      web_contents(), url, kTestPackageName, reference_time));
-
-  service->AddPoints(url, 1.5);
-  EXPECT_TRUE(AppBannerSettingsHelper::ShouldShowBanner(
-      web_contents(), url, kTestPackageName, reference_time));
-}