[NTP Snippets] Show a status card when there are no available snippets

[NTP Snippets] Show a status card when there are no available snippets

Introduce a new NTP item type type: Status cards! They show up when
there are no snippets to display and let the user know that the NTP
is not broken. The current one simply acknowledges that we ran out
of snippets and allows to manually fetch more.

This CL also refactors some basic card features out of Snippet specific
classes.

Known issues that will be addressed in future CLs:
- Show a different message if the service can't fetch snippets but the
user can fix it, for example by enabling sync.
- The card should be animated as coming from below

BUG=612508
Committed: https://crrev.com/12fae2360889eba5e18e00ce641d95cb4a814159
Cr-Commit-Position: refs/heads/master@{#399202}

[dgn, 2016-06-02 16:04:40]

Description was changed from

==========
[NTP Snippets] Show a status card when there are no available snippets

WIP. Known issues:

- logs, hardcoded strings, etc.
- When dismissing the last snippet, some extra space is added at the
bottom
- The reload button does nothing
- The card has no bleed when peeking above the fold.

BUG=612508
==========

to

==========
[NTP Snippets] Show a status card when there are no available snippets

WIP. Known issues:

- When dismissing the last snippet, some extra space is added at the
bottom
- The reload button does nothing

BUG=612508
==========

[dgn, 2016-06-02 16:05:37]

Description was changed from

==========
[NTP Snippets] Show a status card when there are no available snippets

WIP. Known issues:

- When dismissing the last snippet, some extra space is added at the
bottom
- The reload button does nothing

BUG=612508
==========

to

==========
[NTP Snippets] Show a status card when there are no available snippets

WIP. Known issues:

- When dismissing the last snippet, some extra space is added at the
bottom
- The reload button does nothing
- The card should be animated as coming from below

BUG=612508
==========

[dgn, 2016-06-02 22:49:23]

Description was changed from

==========
[NTP Snippets] Show a status card when there are no available snippets

WIP. Known issues:

- When dismissing the last snippet, some extra space is added at the
bottom
- The reload button does nothing
- The card should be animated as coming from below

BUG=612508
==========

to

==========
[NTP Snippets] Show a status card when there are no available snippets

WIP. Known issues:

- Logs here and there.
- The bottom spacing is sometimes not right when few snippets are added after a
reload.
- The reload card is sometimes displayed in the peeking state (with bleed and
blank).
- The card should be animated as coming from below (will be done in another CL)

BUG=612508
==========

[dgn, 2016-06-02 22:50:39]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org, mcwilliams@chromium.org

[dgn, 2016-06-02 22:50:40]

PTAL. Not completely finished. Should be stable enough though, I'm chasing the
last bugs and glitches.

[Bernhard Bauer, 2016-06-03 14:12:10]

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:181:
return new StatusListItem.ViewHolder(StatusListItem.sLayout, parent, this);
Why do you need to pass in the layout resource ID?

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:198:
*
Javadoc

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:45:
*
Javadoc

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:53:
public void onAnimationStart(Animator arg0) {}
Clean up the parameter names please.

[dgn, 2016-06-03 21:02:07]

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:181:
return new StatusListItem.ViewHolder(StatusListItem.sLayout, parent, this);
On 2016/06/03 14:12:10, Bernhard Bauer wrote:
> Why do you need to pass in the layout resource ID?

I replaced the multiple createView() functions with a single one in
CardViewHolder, and it just takes an xml to inflate. No specific reason though,
reverting to having the view be created by the ListItem or the ViewHolder class
would not require more than changing the constructors.

[Bernhard Bauer, 2016-06-07 16:10:08]

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:181:
return new StatusListItem.ViewHolder(StatusListItem.sLayout, parent, this);
On 2016/06/03 21:02:07, dgn wrote:
> On 2016/06/03 14:12:10, Bernhard Bauer wrote:
> > Why do you need to pass in the layout resource ID?
> 
> I replaced the multiple createView() functions with a single one in
> CardViewHolder, and it just takes an xml to inflate. No specific reason
though,
> reverting to having the view be created by the ListItem or the ViewHolder
class
> would not require more than changing the constructors.

Yes, but here you are calling the constructor for StatusListItem.ViewHolder. You
could just remove the parameter and have the constructor pass the ID to its
super constructor.

[dgn, 2016-06-07 17:25:37]

Description was changed from

==========
[NTP Snippets] Show a status card when there are no available snippets

WIP. Known issues:

- Logs here and there.
- The bottom spacing is sometimes not right when few snippets are added after a
reload.
- The reload card is sometimes displayed in the peeking state (with bleed and
blank).
- The card should be animated as coming from below (will be done in another CL)

BUG=612508
==========

to

==========
[NTP Snippets] Show a status card when there are no available snippets

Introduce a new NTP item type type: Status cards! They show up when
there are no snippets to display and let the user know that the NTP
is not broken. The current one simply acknowledges that we ran out
of snippets and allows to manually fetch more.

This CL also refactors some basic card features out of Snippet specific
classes.

Known issues that will be addressed in future CLs:
- Show a different message if the service can't fetch snippets but the
user can fix it, for example by enabling sync.
- The card should be animated as coming from below

BUG=612508
==========

[dgn, 2016-06-07 17:34:47]

PTAL

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:181:
return new StatusListItem.ViewHolder(StatusListItem.sLayout, parent, this);
On 2016/06/07 16:10:08, Bernhard Bauer wrote:
> On 2016/06/03 21:02:07, dgn wrote:
> > On 2016/06/03 14:12:10, Bernhard Bauer wrote:
> > > Why do you need to pass in the layout resource ID?
> > 
> > I replaced the multiple createView() functions with a single one in
> > CardViewHolder, and it just takes an xml to inflate. No specific reason
> though,
> > reverting to having the view be created by the ListItem or the ViewHolder
> class
> > would not require more than changing the constructors.
> 
> Yes, but here you are calling the constructor for StatusListItem.ViewHolder.
You
> could just remove the parameter and have the constructor pass the ID to its
> super constructor.

Ah right! Done, thanks.

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:198:
*
On 2016/06/03 14:12:10, Bernhard Bauer wrote:
> Javadoc

Done.

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:45:
*
On 2016/06/03 14:12:10, Bernhard Bauer wrote:
> Javadoc

Done.

https://codereview.chromium.org/2024933002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:53:
public void onAnimationStart(Animator arg0) {}
On 2016/06/03 14:12:10, Bernhard Bauer wrote:
> Clean up the parameter names please.

Done.

https://codereview.chromium.org/2024933002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardItemDecoration.java
(right):

https://codereview.chromium.org/2024933002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardItemDecoration.java:17:
public class CardItemDecoration extends RecyclerView.ItemDecoration {
moved/renamed SnippetItemDecoration, replaced view type checking by instanceof
checks.

https://codereview.chromium.org/2024933002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsLayoutOperations.java
(left):

https://codereview.chromium.org/2024933002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsLayoutOperations.java:103:
if (snippetHeader == null || !snippetHeader.isShown()) return;
Relies on View#getVisibility(), but when the status card is show, the header
would be set to INVISIBLE, so it's not going to be accurate. We still want to
animate the header in that case to make sure the rest of the animations are
correct.

[Bernhard Bauer, 2016-06-08 12:36:00]

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java:66:
((NewTabPageView) v.getParent().getParent()).showCardsFrom(mPeekPadding);
Could you just pass in the NewTabPageView in the constructor and store it in a
member?

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:232:
mRecyclerView.refreshHeaderVisibility();
Hm... would it work to call notifyItemChanged() with the index of the header
list item, which should call onBindViewHolder() on this object (which dispatches
it to the ViewHolder itself), and then in there call animateFade()? The idea
being that the ViewHolder itself should know when to start fading, as opposed to
the adapter driving that. And then similarly for the spacing item.

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java:160:
// next pass.Known cases that make it necessary:
Nit: space after period.

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java:166:
bottomSpacing = getHeight() - mToolbarHeight;
You start out with `getHeight() - mToolbarHeight` in both cases, so you could
pull that out and only adjust in the if/else statement.

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:37:
itemView.setVisibility(mHeader.isVisible() ? View.VISIBLE : View.INVISIBLE);
You could maybe extract this to a method shared with the animation below.

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:38:
itemView.setAlpha(mHeader.isVisible() ? 1f : 0f);
Same for the (target) alpha calculation.

[dgn, 2016-06-09 11:41:14]

PTAL

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java:66:
((NewTabPageView) v.getParent().getParent()).showCardsFrom(mPeekPadding);
On 2016/06/08 12:36:00, Bernhard Bauer wrote:
> Could you just pass in the NewTabPageView in the constructor and store it in a
> member?

I moved the function to the recyclerview and just use it, since it's already an
argument (parent)

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:232:
mRecyclerView.refreshHeaderVisibility();
On 2016/06/08 12:36:00, Bernhard Bauer wrote:
> Hm... would it work to call notifyItemChanged() with the index of the header
> list item, which should call onBindViewHolder() on this object (which
dispatches
> it to the ViewHolder itself), and then in there call animateFade()? The idea
> being that the ViewHolder itself should know when to start fading, as opposed
to
> the adapter driving that. And then similarly for the spacing item.

Thanks, it works!

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java:160:
// next pass.Known cases that make it necessary:
On 2016/06/08 12:36:00, Bernhard Bauer wrote:
> Nit: space after period.

Done.

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java:166:
bottomSpacing = getHeight() - mToolbarHeight;
On 2016/06/08 12:36:00, Bernhard Bauer wrote:
> You start out with `getHeight() - mToolbarHeight` in both cases, so you could
> pull that out and only adjust in the if/else statement.

Done.

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:37:
itemView.setVisibility(mHeader.isVisible() ? View.VISIBLE : View.INVISIBLE);
On 2016/06/08 12:36:00, Bernhard Bauer wrote:
> You could maybe extract this to a method shared with the animation below.

Done.

https://codereview.chromium.org/2024933002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:38:
itemView.setAlpha(mHeader.isVisible() ? 1f : 0f);
On 2016/06/08 12:36:00, Bernhard Bauer wrote:
> Same for the (target) alpha calculation.

Done.

[Bernhard Bauer, 2016-06-09 12:51:44]

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:87:
((CardViewHolder) viewHolder).updateTransparencyForDismiss(dX);
Could we make this and isDismissable part of NewTabPageViewHolder? I would also
maybe not make it part of the name that this updates the transparency, just that
it should update the view state when it's being swiped/dismised?

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:55:
float targetAlpha = getAlphaForHeaderVisibility();
Heh, now that you're using this from onBindViewHolder, you could even inline
these methods, because they're only used once! :) And in fact, you could inline
animateFade() as well. Up to you.

[dgn, 2016-06-09 20:29:55]

PTAL

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
(right):

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:87:
((CardViewHolder) viewHolder).updateTransparencyForDismiss(dX);
On 2016/06/09 12:51:44, Bernhard Bauer wrote:
> Could we make this and isDismissable part of NewTabPageViewHolder? I would
also
> maybe not make it part of the name that this updates the transparency, just
that
> it should update the view state when it's being swiped/dismised?

Done.

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:55:
float targetAlpha = getAlphaForHeaderVisibility();
On 2016/06/09 12:51:44, Bernhard Bauer wrote:
> Heh, now that you're using this from onBindViewHolder, you could even inline
> these methods, because they're only used once! :) And in fact, you could
inline
> animateFade() as well. Up to you.

Inlined the elvis methods. I'm happy with animateFade separate, as
onBindViewHolder is a framework method, I like to have them fairly simple.

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsLayoutOperations.java
(right):

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsLayoutOperations.java:58:
((SnippetHeaderViewHolder)
viewHolder).animateFadeForScrollChange(omniBoxHeight);
Moved this out too so that I can check if the header should be visible. and
avoid fading it back in when it should not.

[Bernhard Bauer, 2016-06-10 08:42:02]

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:27:
private int mMaxSnippetHeaderHeight;
Make this final?

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:51:
public void animateFadeForScrollChange(int omniBoxHeight) {
Maybe not "animateFade..." if we have another animateFade... method below that
actually triggers an animation? Maybe just onScrolled()?

[dgn, 2016-06-10 11:14:31]

PTAL

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:27:
private int mMaxSnippetHeaderHeight;
On 2016/06/10 08:42:02, Bernhard Bauer wrote:
> Make this final?

Done.

https://codereview.chromium.org/2024933002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:51:
public void animateFadeForScrollChange(int omniBoxHeight) {
On 2016/06/10 08:42:02, Bernhard Bauer wrote:
> Maybe not "animateFade..." if we have another animateFade... method below that
> actually triggers an animation? Maybe just onScrolled()?

Done.

[Bernhard Bauer, 2016-06-10 13:42:25]

LGTM, just one final thought that occurred to me:

https://codereview.chromium.org/2024933002/diff/200001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/200001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:93:
float targetAlpha = mHeader.isVisible() ? 1f : 0f;
Return early if target is equal to current?

[dgn, 2016-06-10 15:12:59]

The CQ bit was checked by dgn@chromium.org

[dgn, 2016-06-10 15:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2024933002/#ps220001
(title: "rebased and address comments")

[commit-bot: I haz the power, 2016-06-10 15:13:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024933002/220001

[dgn, 2016-06-10 15:15:22]

Thanks!

https://codereview.chromium.org/2024933002/diff/200001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java
(right):

https://codereview.chromium.org/2024933002/diff/200001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java:93:
float targetAlpha = mHeader.isVisible() ? 1f : 0f;
On 2016/06/10 13:42:25, Bernhard Bauer wrote:
> Return early if target is equal to current?

Done. Also fixed onScrolled.

[commit-bot: I haz the power, 2016-06-10 16:21:04]

Description was changed from

==========
[NTP Snippets] Show a status card when there are no available snippets

Introduce a new NTP item type type: Status cards! They show up when
there are no snippets to display and let the user know that the NTP
is not broken. The current one simply acknowledges that we ran out
of snippets and allows to manually fetch more.

This CL also refactors some basic card features out of Snippet specific
classes.

Known issues that will be addressed in future CLs:
- Show a different message if the service can't fetch snippets but the
user can fix it, for example by enabling sync.
- The card should be animated as coming from below

BUG=612508
==========

to

==========
[NTP Snippets] Show a status card when there are no available snippets

Introduce a new NTP item type type: Status cards! They show up when
there are no snippets to display and let the user know that the NTP
is not broken. The current one simply acknowledges that we ran out
of snippets and allows to manually fetch more.

This CL also refactors some basic card features out of Snippet specific
classes.

Known issues that will be addressed in future CLs:
- Show a different message if the service can't fetch snippets but the
user can fix it, for example by enabling sync.
- The card should be animated as coming from below

BUG=612508
==========

[commit-bot: I haz the power, 2016-06-10 16:21:05]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-06-10 16:21:13]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 16:22:22]

Description was changed from

==========
[NTP Snippets] Show a status card when there are no available snippets

Introduce a new NTP item type type: Status cards! They show up when
there are no snippets to display and let the user know that the NTP
is not broken. The current one simply acknowledges that we ran out
of snippets and allows to manually fetch more.

This CL also refactors some basic card features out of Snippet specific
classes.

Known issues that will be addressed in future CLs:
- Show a different message if the service can't fetch snippets but the
user can fix it, for example by enabling sync.
- The card should be animated as coming from below

BUG=612508
==========

to

==========
[NTP Snippets] Show a status card when there are no available snippets

Introduce a new NTP item type type: Status cards! They show up when
there are no snippets to display and let the user know that the NTP
is not broken. The current one simply acknowledges that we ran out
of snippets and allows to manually fetch more.

This CL also refactors some basic card features out of Snippet specific
classes.

Known issues that will be addressed in future CLs:
- Show a different message if the service can't fetch snippets but the
user can fix it, for example by enabling sync.
- The card should be animated as coming from below

BUG=612508

Committed: https://crrev.com/12fae2360889eba5e18e00ce641d95cb4a814159
Cr-Commit-Position: refs/heads/master@{#399202}
==========

[commit-bot: I haz the power, 2016-06-10 16:22:24]

Patchset 12 (id:??) landed as
https://crrev.com/12fae2360889eba5e18e00ce641d95cb4a814159
Cr-Commit-Position: refs/heads/master@{#399202}