Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024923002: [Android] Add five APK targets to gn_all. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, maxbogue
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add five APK targets to gn_all. BUG= Committed: https://crrev.com/5d0af4b4cd4b660b660ed3f9b2abfa04dcb9dca9 Cr-Commit-Position: refs/heads/master@{#396923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 6 months ago (2016-05-31 14:14:04 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-05-31 19:24:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024923002/1
4 years, 6 months ago (2016-05-31 19:51:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 20:55:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5d0af4b4cd4b660b660ed3f9b2abfa04dcb9dca9 Cr-Commit-Position: refs/heads/master@{#396923}
4 years, 6 months ago (2016-05-31 20:57:09 UTC) #8
jbudorick
4 years, 6 months ago (2016-06-01 00:46:10 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2020263004/ by jbudorick@chromium.org.

The reason for reverting is: chromium_linker_test_apk doesn't exist on x64.

Powered by Google App Engine
This is Rietveld 408576698