Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024833003: Remove XFA_HFM2JSCONTEXT. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove XFA_HFM2JSCONTEXT. This CL removes XFA_HFM2JSCONTEXT and the supporting code. XFA_HFM2JSCONTEXT was replaced by CXFA_FM2JSContext. The translate method was moved to CXFA_FM2JSContext. Committed: https://pdfium.googlesource.com/pdfium/+/e80e9f8fc221a7639b6a38bd46bc44bca26481d0

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -138 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D xfa/fxfa/fm2js/xfa_fm2jsapi.h View 1 chunk +0 lines, -35 lines 0 comments Download
D xfa/fxfa/fm2js/xfa_fm2jsapi.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 4 chunks +29 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_layout_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 6 chunks +11 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-01 04:00:18 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2024833003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscontext.h File xfa/fxfa/fm2js/xfa_fm2jscontext.h (right): https://codereview.chromium.org/2024833003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscontext.h#newcode442 xfa/fxfa/fm2js/xfa_fm2jscontext.h:442: int32_t Translate(const CFX_WideStringC& wsFormcalc, static?
4 years, 6 months ago (2016-06-01 07:27:42 UTC) #3
dsinclair
https://codereview.chromium.org/2024833003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscontext.h File xfa/fxfa/fm2js/xfa_fm2jscontext.h (right): https://codereview.chromium.org/2024833003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscontext.h#newcode442 xfa/fxfa/fm2js/xfa_fm2jscontext.h:442: int32_t Translate(const CFX_WideStringC& wsFormcalc, On 2016/06/01 07:27:42, Lei Zhang ...
4 years, 6 months ago (2016-06-01 13:01:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024833003/20001
4 years, 6 months ago (2016-06-01 13:01:26 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:10:10 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e80e9f8fc221a7639b6a38bd46bc44bca264...

Powered by Google App Engine
This is Rietveld 408576698