Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2024813003: Split SocketWatcher and SocketWatcherFactory out of NQE (Closed)

Created:
4 years, 6 months ago by tbansal1
Modified:
4 years, 6 months ago
Reviewers:
bengr, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split SocketWatcher and SocketWatcherFactory out of NQE This is a simple refactoring CL, and does not involve any functionality change. BUG=616302 Committed: https://crrev.com/1972027ec61177ec63f2cebaea55890c24d87f62 Cr-Commit-Position: refs/heads/master@{#398250}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Addressed bengr comments #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -83 lines) Patch
M net/net.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 1 4 chunks +5 lines, -79 lines 0 comments Download
A net/nqe/socket_watcher.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A net/nqe/socket_watcher.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A net/nqe/socket_watcher_factory.h View 1 1 chunk +66 lines, -0 lines 0 comments Download
A net/nqe/socket_watcher_factory.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
tbansal1
bengr PTAL. Thanks.
4 years, 6 months ago (2016-05-31 23:46:58 UTC) #6
bengr
https://codereview.chromium.org/2024813003/diff/60001/net/nqe/network_quality_estimator.cc File net/nqe/network_quality_estimator.cc (left): https://codereview.chromium.org/2024813003/diff/60001/net/nqe/network_quality_estimator.cc#oldcode17 net/nqe/network_quality_estimator.cc:17: #include "base/single_thread_task_runner.h" Is this needed anymore? https://codereview.chromium.org/2024813003/diff/60001/net/nqe/socket_watcher.h File net/nqe/socket_watcher.h ...
4 years, 6 months ago (2016-06-01 17:41:04 UTC) #8
tbansal1
bengr: ptal. Thanks. https://codereview.chromium.org/2024813003/diff/60001/net/nqe/network_quality_estimator.cc File net/nqe/network_quality_estimator.cc (left): https://codereview.chromium.org/2024813003/diff/60001/net/nqe/network_quality_estimator.cc#oldcode17 net/nqe/network_quality_estimator.cc:17: #include "base/single_thread_task_runner.h" On 2016/06/01 17:41:04, bengr ...
4 years, 6 months ago (2016-06-01 18:24:37 UTC) #10
bengr
lgtm
4 years, 6 months ago (2016-06-02 23:03:53 UTC) #11
tbansal1
mmenke: PTAL at net.gypi. Thanks.
4 years, 6 months ago (2016-06-02 23:07:32 UTC) #13
mmenke
On 2016/06/02 23:07:32, tbansal1 wrote: > mmenke: PTAL at net.gypi. Thanks. net.gypi LGTM, rubberstamp.
4 years, 6 months ago (2016-06-06 14:32:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024813003/120001
4 years, 6 months ago (2016-06-07 07:17:14 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:120001)
4 years, 6 months ago (2016-06-07 08:12:27 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 08:15:18 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1972027ec61177ec63f2cebaea55890c24d87f62
Cr-Commit-Position: refs/heads/master@{#398250}

Powered by Google App Engine
This is Rietveld 408576698