Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2024783003: Support references to unserialized libraries. (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org, Harry Terkelsen
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support references to unserialized libraries. This adds initial support for combining serialized and unserialized libraries even in the case where the serialized library refers to the unserialized library. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ac1bc765d9443bda5f1270a7502d79cbb2831364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -21 lines) Patch
M pkg/compiler/lib/src/library_loader.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 6 chunks +15 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 5 chunks +31 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 5 chunks +15 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 6 months ago (2016-05-31 13:34:53 UTC) #2
Siggi Cherem (dart-lang)
lgtm Not sure if we need to support references from serialized to non-serialized... we might ...
4 years, 6 months ago (2016-05-31 21:43:40 UTC) #3
Johnni Winther
On 2016/05/31 21:43:40, Siggi Cherem (dart-lang) wrote: > lgtm > > Not sure if we ...
4 years, 6 months ago (2016-06-02 08:33:29 UTC) #4
Johnni Winther
4 years, 6 months ago (2016-06-02 08:39:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac1bc765d9443bda5f1270a7502d79cbb2831364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698