Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: chrome/browser/safe_browsing/permission_reporter.cc

Issue 2024753002: Add permission reporter skeleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@protocol-buffer-for-permission-reports
Patch Set: Change SendReport function signature Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/safe_browsing/permission_reporter.h"
6 #include "chrome/common/safe_browsing/permission_report.pb.h"
7 #include "content/public/browser/permission_type.h"
8
9 using content::PermissionType;
10
11 namespace safe_browsing {
12
13 namespace {
14 // URL to upload permission action reports.
15 static const char kPermissionActionReportingUploadUrl[] =
Nathan Parker 2016/06/06 22:55:49 No need to say "static" if it's in an anonymous na
stefanocs 2016/06/07 03:07:44 Done.
16 "http://safebrowsing.googleusercontent.com/safebrowsing/clientreport/"
17 "permission-action";
18 } // namespace
19
20 PermissionReporter::PermissionReporter(net::URLRequestContext* request_context)
21 : upload_url_(kPermissionActionReportingUploadUrl) {}
Nathan Parker 2016/06/06 22:55:49 You probably don't need this as a member of the cl
stefanocs 2016/06/07 03:07:44 Done.
22
23 PermissionReporter::~PermissionReporter() {}
24
25 void PermissionReporter::SendReport(const GURL& origin,
26 content::PermissionType permission,
27 PermissionAction action) {
28 // TODO(stefanocs): Implement SendReport function.
Nathan Parker 2016/06/06 22:55:49 I'm assuming this will use a ReportSender, when th
stefanocs 2016/06/07 03:07:44 Yes, that's right.
29 }
30
31 // static
32 bool PermissionReporter::BuildReport(const GURL& origin,
33 PermissionType permission,
34 PermissionAction action,
35 std::string* output) {
36 // TODO(stefanocs): Implement BuildReport function.
37 return true;
38 }
39
40 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698