OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #include "chrome/browser/safe_browsing/permission_reporter.h" | |
6 | |
7 using content::PermissionType; | |
8 | |
9 namespace safe_browsing { | |
10 | |
11 PermissionReporter::PermissionReporter( | |
12 net::URLRequestContext* request_context, | |
stefanocs
2016/05/31 03:34:22
Should I move this up to the previous line too?
kcarattini
2016/05/31 03:53:36
Sounds good but I think you need to fix the indent
stefanocs
2016/05/31 04:04:12
Done.
| |
13 const GURL& upload_url) | |
14 : permission_report_sender_(new net::CertificateReportSender( | |
15 request_context, | |
16 net::CertificateReportSender:: | |
17 CookiesPreference::DO_NOT_SEND_COOKIES)), | |
18 upload_url_(upload_url) { | |
19 DCHECK(permission_report_sender_); | |
20 DCHECK(!upload_url.is_empty()); | |
21 } | |
22 | |
23 PermissionReporter::~PermissionReporter() {} | |
24 | |
25 void PermissionReporter::SendReport(const std::string& serialized_report) { | |
26 // TODO(stefanocs): Implement SendReport function | |
kcarattini
2016/05/31 03:13:37
Add a full stop.
stefanocs
2016/05/31 03:34:22
Done.
| |
27 } | |
28 | |
29 PermissionReport PermissionReporter::BuildReport( | |
30 const GURL& origin, | |
stefanocs
2016/05/31 03:34:22
And move this up to the previous line?
kcarattini
2016/05/31 03:53:36
sounds good. Thanks for catching this.
stefanocs
2016/05/31 04:04:12
Done.
| |
31 PermissionType permission, | |
32 PermissionAction action) { | |
33 // TODO(stefanocs): Implement BuildReport function | |
kcarattini
2016/05/31 03:13:37
Add a full stop.
stefanocs
2016/05/31 03:34:22
Done.
| |
34 return PermissionReport(); | |
35 } | |
36 | |
37 } // namespace safe_browsing | |
OLD | NEW |