Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2024703005: Get rid of an unused function FrameSelection::setNonDirectionalSelectionIfNeeded() (Closed)

Created:
4 years, 6 months ago by yosin_UTC9
Modified:
4 years, 6 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of an unused function FrameSelection::setNonDirectionalSelectionIfNeeded() for VisibleSelection This patch gets rid of an unused function |VisibleSelection| version of |FrameSelection::setNonDirectionalSelectionIfNeeded()| to reduce source code size for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/35a88f876eeebe4db340eb37852a3e6d9e1a23e6 Cr-Commit-Position: refs/heads/master@{#397084}

Patch Set 1 : 2016-06-01T14:05:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 6 months ago (2016-06-01 05:22:30 UTC) #3
yoichio
lgtm
4 years, 6 months ago (2016-06-01 06:48:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024703005/1
4 years, 6 months ago (2016-06-01 06:54:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 08:33:24 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 08:35:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35a88f876eeebe4db340eb37852a3e6d9e1a23e6
Cr-Commit-Position: refs/heads/master@{#397084}

Powered by Google App Engine
This is Rietveld 408576698