Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: src/heap/incremental-marking.cc

Issue 2024613002: Version 5.1.281.54 (cherry-pick) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@5.1
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8-version.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/incremental-marking.cc
diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc
index c82fc83ff7fc361eb730dd09f14620578027f35f..e87f1a96337ab81e36511778ef82441b7d6a2e06 100644
--- a/src/heap/incremental-marking.cc
+++ b/src/heap/incremental-marking.cc
@@ -568,7 +568,7 @@ void IncrementalMarking::StartMarking() {
IncrementalMarkingRootMarkingVisitor visitor(this);
heap_->IterateStrongRoots(&visitor, VISIT_ONLY_STRONG);
- if (FLAG_black_allocation) {
+ if (FLAG_black_allocation && !heap()->ShouldReduceMemory()) {
StartBlackAllocation();
}
@@ -591,9 +591,11 @@ void IncrementalMarking::StartBlackAllocation() {
}
void IncrementalMarking::FinishBlackAllocation() {
- black_allocation_ = false;
- if (FLAG_trace_incremental_marking) {
- PrintF("[IncrementalMarking] Black allocation finished\n");
+ if (black_allocation_) {
+ black_allocation_ = false;
+ if (FLAG_trace_incremental_marking) {
+ PrintF("[IncrementalMarking] Black allocation finished\n");
+ }
}
}
@@ -767,6 +769,12 @@ void IncrementalMarking::FinalizeIncrementally() {
(marking_progress <
FLAG_min_progress_during_incremental_marking_finalization)) {
finalize_marking_completed_ = true;
+
+ // If black allocation was not enabled earlier, start black allocation
+ // here.
+ if (FLAG_black_allocation && !black_allocation_) {
+ StartBlackAllocation();
+ }
}
}
« no previous file with comments | « include/v8-version.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698