Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 2024603002: [Autofill] Register AutofillDriver mojo interface earlier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 763e389bfec0827f40d0c0670bc822813006c917..729cbf60e2317e0c06cb96fdcf5b720886b4652f 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -771,7 +771,8 @@ void AutofillAgent::ajaxSucceeded() {
}
void AutofillAgent::ConnectToMojoAutofillDriverIfNeeded() {
- if (mojo_autofill_driver_)
+ if (mojo_autofill_driver_.is_bound() &&
vabr (Chromium) 2016/05/30 10:16:09 Would this crash on every first call, because mojo
leonhsl(Using Gerrit) 2016/05/30 10:52:01 InterfacePtr is a wrapper class maybe containing o
vabr (Chromium) 2016/05/30 10:58:20 Acknowledged, thanks for the explanation.
+ !mojo_autofill_driver_.encountered_error())
return;
render_frame()->GetServiceRegistry()->ConnectToRemoteService(
« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698