third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html - Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/event-attributes-expected.txt ('k') | third_party/WebKit/LayoutTests/media/invalid-media-url-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

diff --git a/third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html b/third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

index 7931f70091d9284e196303cb4e384ccca1c4abfb..12a2ae24c5570d9dc83d9328bf15c70fa101b8c7 100644

--- a/third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

+++ b/third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

@@ -1,34 +1,20 @@

-<html>

- <body>

- <p>Tests that invalid media src url does not result in crash.</p>

- <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

- <script src=video-test.js></script>

- <script>

- var invalid_url = "!:/" + String.fromCharCode(0) + "%aa#aa";

- var error_count = 0;

+<!DOCTYPE html>

+<title>Tests that invalid media src url does not result in crash.</title>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script>

+function check_invalid_media_src(elementName) {

+ async_test(function(t) {

+ var mediaElement = document.createElement(elementName);

+ mediaElement.src = "!:/" + String.fromCharCode(0) + "%aa#aa";

- function errorEvent()

- {

- error_count++;

- if (error_count == 2)

- {

- testExpected("audio.error.code", MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);

- testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);

- testExpected("audio.networkState", HTMLMediaElement.NETWORK_NO_SOURCE);

- testExpected("video.networkState", HTMLMediaElement.NETWORK_NO_SOURCE);

- endTest();

- }

+ mediaElement.onerror = t.step_func_done(function() {

+ assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);

+ assert_equals(mediaElement.networkState, HTMLMediaElement.NETWORK_NO_SOURCE);

+ });

- var audio = document.createElement('audio');

- var video = document.createElement('video');

- audio.src = invalid_url;

- video.src = invalid_url;

- audio.onerror = errorEvent;

- video.onerror = errorEvent;

- document.body.appendChild(audio);

- document.body.appendChild(video);

- </script>

- </body>

-</html>

+check_invalid_media_src("audio");

+check_invalid_media_src("video");

+</script>