third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html - Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js

Side by Side Diff: third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/event-attributes.html ('K') | « third_party/WebKit/LayoutTests/media/event-attributes-expected.txt ('k') | third_party/WebKit/LayoutTests/media/invalid-media-url-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <!DOCTYPE html>

2 <body>	2 <title>Tests that invalid media src url does not result in crash.</title>

3 <p>Tests that invalid media src url does not result in crash.</p>	3 <script src="../resources/testharness.js"></script>

4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	4 <script src="../resources/testharnessreport.js"></script>

5 (Please avoid writing new tests using video-test.js) -->	5 <body>

6 <script src=video-test.js></script>	6 <script>

7 <script>	7 function check_invalid_media_src(elementName) {

8 var invalid_url = "!:/" + String.fromCharCode(0) + "%aa#aa";	8 async_test(function(t) {

9 var error_count = 0;	9 var invalid_url = "!:/" + String.fromCharCode(0) + "%aa#aa";

10	10

11 function errorEvent()	11 var mediaElement = document.createElement(elementName);

12 {	12 mediaElement.src = invalid_url;

13 error_count++;	13 mediaElement.onerror = t.step_func_done(errorEvent);
	foolip 2016/05/31 10:50:18 Suggest just inlining the errorEvent method so tha Suggest just inlining the errorEvent method so that it doesn't need to have a name. Srirama 2016/05/31 13:23:28 Done. Show quoted text On 2016/05/31 10:50:18, Philip Jägenstedt wrote: > Suggest just inlining the errorEvent method so that it doesn't need to have a > name. Done.
14 if (error_count == 2)	14 document.body.appendChild(mediaElement);
	foolip 2016/05/31 10:50:18 This shouldn't be neeed, it's probably here to sol This shouldn't be neeed, it's probably here to solve a GC problem that I hope is no longer present. Srirama 2016/05/31 13:23:28 Done. Show quoted text On 2016/05/31 10:50:18, Philip Jägenstedt wrote: > This shouldn't be neeed, it's probably here to solve a GC problem that I hope is > no longer present. Done.
15 {

16 testExpected("audio.error.code", MediaError.MEDIA_ERR_SRC_NO T_SUPPORTED);

17 testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NO T_SUPPORTED);

18 testExpected("audio.networkState", HTMLMediaElement.NETWORK_ NO_SOURCE);

19 testExpected("video.networkState", HTMLMediaElement.NETWORK_ NO_SOURCE);

20 endTest();

21 }

22 }

23	15

24 var audio = document.createElement('audio');	16 function errorEvent() {
	fs 2016/05/31 08:53:06 Maybe just have this be anonymous in the step_func Maybe just have this be anonymous in the step_func_done (only place where it's referenced.) Srirama 2016/05/31 13:23:28 Done. Show quoted text On 2016/05/31 08:53:06, fs wrote: > Maybe just have this be anonymous in the step_func_done (only place where it's > referenced.) Done.
25 var video = document.createElement('video');	17 assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_SRC_NOT_ SUPPORTED);

26 audio.src = invalid_url;	18 assert_equals(mediaElement.networkState, HTMLMediaElement.NETWORK_NO _SOURCE);

27 video.src = invalid_url;	19 }

28 audio.onerror = errorEvent;	20 });

29 video.onerror = errorEvent;	21 }

30 document.body.appendChild(audio);	22

31 document.body.appendChild(video);	23 check_invalid_media_src("audio");

32 </script>	24 check_invalid_media_src("video");

33 </body>	25 </script>

34 </html>	26 </body>

OLD	NEW