third_party/WebKit/LayoutTests/media/csp-blocks-video.html - Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/csp-blocks-video.html

Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 <!DOCTYPE html>

	2 <title>Test that "Content-Security-Policy" on a media element is obeyed.</title>

1 <meta http-equiv="Content-Security-Policy" content="media-src 'none'">	3 <meta http-equiv="Content-Security-Policy" content="media-src 'none'">

2 <video controls></video>	4 <video controls></video>

3 <script src=media-file.js></script>	5 <script src="../resources/testharness.js"></script>

4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	6 <script src="../resources/testharnessreport.js"></script>

5 (Please avoid writing new tests using video-test.js) -->	7 <script src="media-file.js"></script>

6 <script src=video-test.js></script>

7 <p>This test passes if it doesn't alert failure.</p>

8 <script>	8 <script>

9 var mediaFile = findMediaFile("video", "content/test");	9 async_test(function(t) {

10 video.src = mediaFile;	10 var video = document.querySelector("video");

	11 video.src = findMediaFile("video", "content/test");

11	12

12 waitForEvent('loadedmetadata', function () {	13 video.onloadedmetadata = t.unreached_func();

13 alert('FAIL');	14 video.load();
	foolip 2016/05/31 10:50:18 This shouldn't be needed, just setting the src att This shouldn't be needed, just setting the src attribute will trigger the media element load algorithm. Srirama 2016/05/31 13:23:28 Done. Show quoted text On 2016/05/31 10:50:18, Philip Jägenstedt wrote: > This shouldn't be needed, just setting the src attribute will trigger the media > element load algorithm. Done.
14 endTest();	15 window.onload = t.step_func_done();
	foolip 2016/05/31 10:50:18 This looks either racy or assuming a bit much know This looks either racy or assuming a bit much knowledge of timing from the reader. I guess that an error event will be fired on the video element, can you use that as the pass condition instead? Srirama 2016/05/31 13:23:28 Done. Show quoted text On 2016/05/31 10:50:18, Philip Jägenstedt wrote: > This looks either racy or assuming a bit much knowledge of timing from the > reader. I guess that an error event will be fired on the video element, can you > use that as the pass condition instead? Done.
15 } );	16 });

16 video.load();

17 addEventListener('load', endTest, false);

18 </script>	17 </script>

OLD	NEW