third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html - Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/invalid-media-url-crash.html

Issue 2024533002: Convert csp-*, event-* and invalid-* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/event-attributes.html ('K') | « third_party/WebKit/LayoutTests/media/event-attributes-expected.txt ('k') | third_party/WebKit/LayoutTests/media/invalid-media-url-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <!DOCTYPE html>

2 <body>	2 <title>Tests that invalid media src url does not result in crash.</title>

3 <p>Tests that invalid media src url does not result in crash.</p>	3 <script src="../resources/testharness.js"></script>

4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	4 <script src="../resources/testharnessreport.js"></script>

5 (Please avoid writing new tests using video-test.js) -->	5 <script>

6 <script src=video-test.js></script>	6 async_test(function(t) {

7 <script>	7 var invalid_url = "!:/" + String.fromCharCode(0) + "%aa#aa";

8 var invalid_url = "!:/" + String.fromCharCode(0) + "%aa#aa";	8 var eventCount = 0;

9 var error_count = 0;

10	9

11 function errorEvent()	10 var audio = document.createElement("audio");
	fs 2016/05/30 09:11:39 Could we turn this into two tests - one per tag-ty Could we turn this into two tests - one per tag-type? (Could even have function to generate them for maximum de-dupe.) Srirama 2016/05/31 07:04:23 Done. Show quoted text On 2016/05/30 09:11:39, fs wrote: > Could we turn this into two tests - one per tag-type? (Could even have function > to generate them for maximum de-dupe.) Done.
12 {	11 var video = document.createElement("video");

13 error_count++;	12 audio.src = invalid_url;

14 if (error_count == 2)	13 video.src = invalid_url;

15 {	14 audio.onerror = t.step_func(errorEvent);

16 testExpected("audio.error.code", MediaError.MEDIA_ERR_SRC_NO T_SUPPORTED);	15 video.onerror = t.step_func(errorEvent);

17 testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NO T_SUPPORTED);

18 testExpected("audio.networkState", HTMLMediaElement.NETWORK_ NO_SOURCE);

19 testExpected("video.networkState", HTMLMediaElement.NETWORK_ NO_SOURCE);

20 endTest();

21 }

22 }

23	16

24 var audio = document.createElement('audio');	17 function errorEvent() {

25 var video = document.createElement('video');	18 eventCount++;

26 audio.src = invalid_url;	19 if (eventCount != 2)

27 video.src = invalid_url;	20 return;

28 audio.onerror = errorEvent;	21

29 video.onerror = errorEvent;	22 assert_equals(audio.error.code, MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);

30 document.body.appendChild(audio);	23 assert_equals(video.error.code, MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);
fs 2016/05/30 09:11:39 It doesn't look like these have an useful purpose, It doesn't look like these have an useful purpose, but maybe keep them just in case (you never quite know with crash tests...)
31 document.body.appendChild(video);	24 assert_equals(audio.networkState, HTMLMediaElement.NETWORK_NO_SOURCE);

32 </script>	25 assert_equals(video.networkState, HTMLMediaElement.NETWORK_NO_SOURCE);

33 </body>	26 t.done();

34 </html>	27 }

	28 });

	29 </script>

OLD	NEW