Avoid two C-style FX_WCHAR* casts in pdfium

Avoid two C-style FX_WCHAR* casts in pdfium

FX_WCHAR* casts were hiding a number of misuses of narrow strings in
pdfium, which /analyze identified. Now that those are fixed I did a
search for other instances of (FX_WCHAR*) to see if any other bugs
were lurking. No bugs were found but one unnecessary cast and one
that should be a const_cast were identified. This change fixes
those. No behavioral change.

Committed: https://pdfium.googlesource.com/pdfium/+/2f109ab836682cb465270ed303d27955db97d98f

[brucedawson, 2016-05-27 22:53:52]

brucedawson@chromium.org changed reviewers:
+ thestig@chromium.org

[brucedawson, 2016-05-27 22:53:52]

Tiny code improvement to finish off the (FX_WCHAR*)"" fixes. PTAL.

[Lei Zhang, 2016-05-27 23:02:54]

lgtm

[brucedawson, 2016-05-27 23:11:15]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-05-27 23:11:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024463002/1

[commit-bot: I haz the power, 2016-05-27 23:13:17]

Description was changed from

==========
Avoid two C-style FX_WCHAR* casts in pdfium

FX_WCHAR* casts were hiding a number of misuses of narrow strings in
pdfium, which /analyze identified. Now that those are fixed I did a
search for other instances of (FX_WCHAR*) to see if any other bugs
were lurking. No bugs were found but one unnecessary cast and one
that should be a const_cast were identified. This change fixes
those. No behavioral change.
==========

to

==========
Avoid two C-style FX_WCHAR* casts in pdfium

FX_WCHAR* casts were hiding a number of misuses of narrow strings in
pdfium, which /analyze identified. Now that those are fixed I did a
search for other instances of (FX_WCHAR*) to see if any other bugs
were lurking. No bugs were found but one unnecessary cast and one
that should be a const_cast were identified. This change fixes
those. No behavioral change.

Committed:
https://pdfium.googlesource.com/pdfium/+/2f109ab836682cb465270ed303d27955db97...
==========

[commit-bot: I haz the power, 2016-05-27 23:13:18]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/2f109ab836682cb465270ed303d27955db97...