Resynthesize parameters lazily.

Resynthesize parameters lazily.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3e610f2f9ed4aeef318e1d8d5deb6b70abbe6130

[Brian Wilkerson, 2016-05-27 22:38:15]

lgtm

https://codereview.chromium.org/2024453002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2024453002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:3946: return _parameters ?? const
<ParameterElement>[];
Seems like I've seen a lot of code with this same pattern lately. It appears
twice in this CL alone. Would it be useful to define some utility methods
similar to

class UnlinkedParam {
  static List<ParameterElement> deserialize(List<UnlinkedParam>
unlinkedParameters) {
    int length = unlinkedParameters.length;
    ...
  }
}

[scheglov, 2016-05-28 02:00:35]

https://codereview.chromium.org/2024453002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2024453002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:3946: return _parameters ?? const
<ParameterElement>[];
On 2016/05/27 22:38:15, Brian Wilkerson wrote:
> Seems like I've seen a lot of code with this same pattern lately. It appears
> twice in this CL alone. Would it be useful to define some utility methods
> similar to
> 
> class UnlinkedParam {
>   static List<ParameterElement> deserialize(List<UnlinkedParam>
> unlinkedParameters) {
>     int length = unlinkedParameters.length;
>     ...
>   }
> }

Good point.
Done.

[scheglov, 2016-05-28 02:00:50]

Description was changed from

==========
Resynthesize parameters lazily.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Resynthesize parameters lazily.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3e610f2f9ed4aeef318e1d8d5deb6b70abbe6130
==========

[scheglov, 2016-05-28 02:00:51]

Committed patchset #2 (id:20001) manually as
3e610f2f9ed4aeef318e1d8d5deb6b70abbe6130 (presubmit successful).