Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024443002: Turbofan: Modify WASM linkage to store floats using only 4 bytes. (Closed)

Created:
4 years, 6 months ago by bbudge
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turbofan: Modify WASM linkage to store floats using only 4 bytes. Adds instructions for ARM to push floats. LOG=N BUG=v8:4124 Committed: https://crrev.com/817b59c8ad7e9237d93a43a31045285418bbb6d5 Cr-Commit-Position: refs/heads/master@{#36654}

Patch Set 1 #

Patch Set 2 : Fix ia32. #

Patch Set 3 : Fix ia32. #

Total comments: 2

Patch Set 4 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 3 1 chunk +9 lines, -2 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/wasm-linkage.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bbudge
4 years, 6 months ago (2016-06-01 00:14:21 UTC) #2
Benedikt Meurer
LGTM. https://codereview.chromium.org/2024443002/diff/40001/src/compiler/arm/code-generator-arm.cc File src/compiler/arm/code-generator-arm.cc (right): https://codereview.chromium.org/2024443002/diff/40001/src/compiler/arm/code-generator-arm.cc#newcode1212 src/compiler/arm/code-generator-arm.cc:1212: DCHECK(op->representation() == MachineRepresentation::kFloat32); Nit: DCHECK_EQ(MachineRepresentation::kFloat32, op->representation())
4 years, 6 months ago (2016-06-01 03:52:06 UTC) #3
bbudge
https://codereview.chromium.org/2024443002/diff/40001/src/compiler/arm/code-generator-arm.cc File src/compiler/arm/code-generator-arm.cc (right): https://codereview.chromium.org/2024443002/diff/40001/src/compiler/arm/code-generator-arm.cc#newcode1212 src/compiler/arm/code-generator-arm.cc:1212: DCHECK(op->representation() == MachineRepresentation::kFloat32); On 2016/06/01 03:52:06, Benedikt Meurer wrote: ...
4 years, 6 months ago (2016-06-01 17:13:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024443002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024443002/60001
4 years, 6 months ago (2016-06-01 17:13:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-01 17:43:10 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 17:43:59 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/817b59c8ad7e9237d93a43a31045285418bbb6d5
Cr-Commit-Position: refs/heads/master@{#36654}

Powered by Google App Engine
This is Rietveld 408576698