Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2024433002: Rewrite checker_test using reflective tests. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rewrite checker_test using reflective tests. It is just a mechanical transformation. The only kind of changes to the test case code is intentation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3b27a0368d469486f17765b5fde12686c3781b66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3278 lines, -3292 lines) Patch
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +3278 lines, -3292 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
4 years, 6 months ago (2016-05-27 20:38:32 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-05-27 21:18:37 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 3b27a0368d469486f17765b5fde12686c3781b66 (presubmit successful).
4 years, 6 months ago (2016-05-27 21:49:19 UTC) #4
Jennifer Messerly
4 years, 6 months ago (2016-05-29 04:13:19 UTC) #6
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698