Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024403002: Remove pepper_messages.h. (Closed)

Created:
4 years, 6 months ago by Sam McNally
Modified:
4 years, 6 months ago
Reviewers:
Charlie Reis, dcheng
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pepper_messages.h. BUG=616963 Committed: https://crrev.com/2ccd36dd90285fc457dca2ba4f7440012bb5ea40 Cr-Commit-Position: refs/heads/master@{#397605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/pepper_messages.h View 1 chunk +0 lines, -28 lines 0 comments Download
M content/content_common.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Sam McNally
+creis for content/ +dcheng for *message*
4 years, 6 months ago (2016-06-02 03:07:17 UTC) #2
dcheng
rs lgtm
4 years, 6 months ago (2016-06-02 03:32:33 UTC) #3
Charlie Reis
Dead code removal LGTM! Can you list a BUG= line in the CL description?
4 years, 6 months ago (2016-06-02 16:26:17 UTC) #4
Sam McNally
On 2016/06/02 16:26:17, Charlie Reis wrote: > Dead code removal LGTM! Can you list a ...
4 years, 6 months ago (2016-06-02 23:57:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024403002/1
4 years, 6 months ago (2016-06-02 23:59:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 02:51:21 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:54:49 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2ccd36dd90285fc457dca2ba4f7440012bb5ea40
Cr-Commit-Position: refs/heads/master@{#397605}

Powered by Google App Engine
This is Rietveld 408576698