third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp - Issue 2024373002: Replace CSSParserString with StringView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

Issue 2024373002: Replace CSSParserString with StringView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp ('k') | third_party/WebKit/Source/wtf/text/StringView.h » ('j') | third_party/WebKit/Source/wtf/text/StringView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

index a1cf7fbcf16f2f6d58513a2a84e8e2c5a4483f8c..b62d62f8ee59ff8fc357e3369e2b3a6a93d19e2e 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp

@@ -73,7 +73,7 @@ bool CSSVariableResolver::resolveVariableReference(CSSParserTokenRange range, Ve

{

range.consumeWhitespace();

ASSERT(range.peek().type() == IdentToken);

- AtomicString variableName = range.consumeIncludingWhitespace().value();

+ AtomicString variableName = AtomicString(range.consumeIncludingWhitespace().value().toString());

ASSERT(range.atEnd() || (range.peek().type() == CommaToken));

CSSVariableData* variableData = valueForCustomProperty(variableName);

@@ -96,7 +96,7 @@ void CSSVariableResolver::resolveApplyAtRule(CSSParserTokenRange& range,

if (range.peek().type() == SemicolonToken)

range.consume();

- CSSVariableData* variableData = valueForCustomProperty(variableName.value());

+ CSSVariableData* variableData = valueForCustomProperty(AtomicString(variableName.value().toString()));

if (!variableData)

return; // Invalid custom property