third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp - Issue 2024373002: Replace CSSParserString with StringView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp

Issue 2024373002: Replace CSSParserString with StringView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp

index d97f387647ce171c3e0210620efe07c792871c03..c79b197a622e7f2b6505e0335184cccfd011e330 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp

@@ -14,7 +14,7 @@ bool CSSVariableParser::isValidVariableName(const CSSParserToken& token)

if (token.type() != IdentToken)

return false;

- CSSParserString value = token.value();

+ StringView value = token.value();

return value.length() >= 2 && value[0] == '-' && value[1] == '-';

}