Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 202433003: Fix NeedsFullRepaintForPositionedMovementLayout (Closed)

Created:
6 years, 9 months ago by Julien - ping for review
Modified:
6 years, 9 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Fix NeedsFullRepaintForPositionedMovementLayout The logic was just plain wrong: during a position movement layout, we have to invalidate the old and new position as we are shifted. The current code would generate incremental invalidation as it fell down the wrong path. Refactored the code to do what it's supposed to do and added an invalidation test to cover a case where incremental invalidation failed. BUG=352050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169505

Patch Set 1 #

Patch Set 2 : Added some more rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/abspos-shift-image-incorrect-repaint.html View 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/abspos-shift-image-incorrect-repaint-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Julien - ping for review
First bug where removing invalidation exposes an underlying issue in the code. Simple review!
6 years, 9 months ago (2014-03-17 21:20:38 UTC) #1
leviw_travelin_and_unemployed
Makes sense to me. LGTM.
6 years, 9 months ago (2014-03-17 21:58:36 UTC) #2
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-17 22:31:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/202433003/20001
6 years, 9 months ago (2014-03-17 22:31:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 03:23:22 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 03:23:23 UTC) #6
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-19 00:17:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/202433003/20001
6 years, 9 months ago (2014-03-19 00:17:57 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 02:44:09 UTC) #9
Message was sent while issue was closed.
Change committed as 169505

Powered by Google App Engine
This is Rietveld 408576698