Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2024323002: Fixing Regression Bug where context menu doesn't appear on long press (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
index b4ed0a35f1b17d19a49fa166901eae24aadf63fa..d215b2978b9423d4751b6d647565b827baaca669 100644
--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
@@ -131,9 +131,10 @@ static String selectMisspellingAsync(LocalFrame* selectedFrame, String& descript
return markerRange->text();
}
-static bool shouldShowContextMenuFromTouch(const WebContextMenuData& data)
+bool ContextMenuClientImpl::shouldShowContextMenuFromTouch(const WebContextMenuData& data)
{
- return !data.linkURL.isEmpty()
+ return m_webView->page()->settings().alwaysShowContextMenuOnTouch()
+ || !data.linkURL.isEmpty()
|| data.mediaType == WebContextMenuData::MediaTypeImage
|| data.mediaType == WebContextMenuData::MediaTypeVideo
|| data.isEditable;
« no previous file with comments | « third_party/WebKit/Source/web/ContextMenuClientImpl.h ('k') | third_party/WebKit/Source/web/WebSettingsImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698